Shoulder warm up before upper body workout

I'm just doing machines now but I'm warming up like this before my upper body workout. The soreness in my shoulders has gone away.